Filter Statistics: 0.9.9.29 hängt ab

Haben Sie einen Fehler in einem Plugin entdeckt?

Moderator: Forum-Team

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 13. Jul 2007, 22:11

Great! Thanks Dieter.

I think it will be slower on very large files only. I tested it with a 39MB filter.log file and the new version took 12 seconds to display the graph, but with the old version, it took less than 2 seconds. Oh well. It is safer now. :-)

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Dieter » 14. Jul 2007, 10:38

Bob Loeffler hat geschrieben:I tested it with a 39MB filter.log file

39 MB?? :? :?:
I have 3.91 MB, and I never waited 12 seconds. 8)

Regards,
Dieter
Intel(R) Core(TM)2 Duo CPU E8500 3.16 GHz, 3.25 GB Ram, WinXP Home Edition SP3,
Outlook Express 6, Outlook 2007
Intel(R) Core(TM)2 Duo CPU T8100 2.10 GHz, 4.00 GB Ram, Windows 7 Ultimate,
Windows Live Mail, Outlook 2007
T-Online/1&1/Gmx/Strato, Call & Surf Comfort Plus, DSL 16000
Benutzeravatar
Dieter
Assistent
Assistent
 
Beiträge: 1545
Registriert: 14. Sep 2003, 10:16
Wohnort: München

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 15. Jul 2007, 20:55

I also tested a 19MB file and it took 6 or 7 seconds to process. A 206k file took only 1 second. Hopefully everyone will be happy with it.

Regards,

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon michel » 19. Jul 2007, 08:41

Hi Bob!

You can still improve the performance. If you use fgets() (like you did before) to read a block into a buffer. Then check, if the last character is '\n'. If not, read another block until you read the whole line.

This could look like this (not correct C++ code):

Code: Alles auswählen
void readline(FILE *f, std::string &result)
{
  result = "";
  char block[512];
  while (fgets(block, 512, f))
  {
    if (block[strlen(block) - 1] == '\n')
      return;
    result.append(block);
  }
}


I haven't tested this yet, but it should speed up your code.

Sincerely,
Michel
Chuck Norris doesn't kill Spam. He uses Spamihilator! ;-)
Benutzeravatar
michel
Administrator
Administrator
 
Administration
Beta-Tester
Forum-Team
Plugin-Programmierer
 
Beiträge: 4335
Registriert: 22. Mär 2003, 01:16
Wohnort: Buseck

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 20. Jul 2007, 05:31

Hi Michel!

Thanks. I will try this and see if it helps.

Regards,

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Clinamen » 24. Jul 2007, 19:30

Hi Bob,

I downloaded the new filterstat and everything works fine now.
Thanks a lot for this great plugin.
Christian.
Clinamen
Power-User
Power-User
 
Beiträge: 5
Registriert: 20. Jun 2007, 04:53
Wohnort: Arica, Chile

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 25. Jul 2007, 06:23

You are welcome, Christian. I will try to make it faster with Michel's code, but I have not found any free time to do it yet. :-)

Regards,

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 26. Nov 2009, 17:22

Hi all!!!!!

I have been away for a long time, but I am back now! :-)

I found another bug that caused Spamihilator to create a .dmp file, so the fix is in the latest Filter Statistics plugin (v1.1.4) that I will post soon.

Regards,

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon anbuva » 26. Nov 2009, 19:05

Hallo Bob Loeffler!

:D :D :D we have missed you so and are pleased to hear from you again. :D :D :D

Gruß
anbuva
Benutzeravatar
anbuva
Administrator
Administrator
 
Administration
Beta-Tester
Forum-Team
 
Beiträge: 8403
Registriert: 1. Sep 2004, 12:58
Wohnort: Zuhause

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 26. Nov 2009, 21:19

Hi anbuva!

I missed you and everyone else also! Hopefully I'll be around the forum more often now. I don't have that evil girlfriend who took me away a couple years ago. :-)

Here is a link to the new Filter Statistics v1.1.4 installer until Michel can put it in the plug-ins add-ons page:

http://www.peaktopeak.com/spamihilator/ ... _1_1_4.exe

Regards,

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon anbuva » 26. Nov 2009, 21:53

Hallo Bob Loeffler!

Welcome back and feel well. :)
The new filter works without problems. Thanks. :D

Regards
anbuva
Benutzeravatar
anbuva
Administrator
Administrator
 
Administration
Beta-Tester
Forum-Team
 
Beiträge: 8403
Registriert: 1. Sep 2004, 12:58
Wohnort: Zuhause

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 26. Nov 2009, 22:42

Thanks anbuva!

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon michel » 27. Nov 2009, 07:23

Hello Bob!

Nice to have you back! I will upload your new filter today in the evening or tomorrow.

Regards,
Michel
Chuck Norris doesn't kill Spam. He uses Spamihilator! ;-)
Benutzeravatar
michel
Administrator
Administrator
 
Administration
Beta-Tester
Forum-Team
Plugin-Programmierer
 
Beiträge: 4335
Registriert: 22. Mär 2003, 01:16
Wohnort: Buseck

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Andreas_Z » 27. Nov 2009, 07:25

Hello Bob Loeffler!

welcome back and greetings from Germany

Andreas_Z
Core i7 3,4 GHz, 8 GB RAM, Win7 64bit SP1, GDATA Bussiness 11.0
Exchange-Server 2003, VM mit WinXP Pro SP3.
Spami-Online-Hilfe, Spami-FAQ, Anbuva's FAQ
Benutzeravatar
Andreas_Z
Administrator
Administrator
 
Administration
Beta-Tester
Forum-Team
 
Beiträge: 4380
Registriert: 6. Nov 2003, 08:10
Wohnort: Schwielowsee, Germany

Re: Filter Statistics: 0.9.9.29 hängt ab

Beitragvon Bob Loeffler » 27. Nov 2009, 16:52

Hi Michel and AndreasZ! I am glad that you are both still here!!!!

Thanks Michel!

Regards,

Bob
English Spamihilator FAQ - Spamihilator questions and answers in English!
Author of these plugins and filters: Attachment Extensions Filter, Empty Mail Filter, HTML Links Filter, No Comment! Filter, Plain Text Links Filter, Scripts Filter, Unclassified Filter, Export Senders Plugin and Filter Statistics Plugin. See the details here!
Benutzeravatar
Bob Loeffler
 
Forum-Team
Plugin-Programmierer
 
Beiträge: 1132
Registriert: 5. Dez 2003, 20:20
Wohnort: Colorado, USA

VorherigeNächste

Zurück zu Plugins: Bugs

Wer ist online?

Mitglieder in diesem Forum: 0 Mitglieder und 2 Gäste

 industrious-southeast